Merge pull request #23 from Aviio/distcc

Fixes distcc vulnerability issue and removes environment warnings

config/scenario.xml

@@ -2,19 +2,17 @@
 	<!-- an example remote storage system, with a remotely exploitable vulnerability that can then be escalated to root -->
 	<system id="storageserver" os="linux" basebox="debian-puppet-64" url="" >
 		<vulnerabilities>
-
+			<vulnerability type="misc"/>
 		</vulnerabilities>
 		<!-- secure services will be provided, if matching insecure ones have not been selected -->
+
 		<services>
-			<service name="lamp" type="lamp"></service>
+
 		</services>-->
 		<networks>
 			<network name="homeonly"></network>
 		</networks>
 
-		<sites>
-			<site type="blog"></site>
-		</sites>
 	</system>
 
 	<!-- an example remote web server, with a remotely exploitable root vulnerability -->

lib/helpers/vulnerability_processor.rb

@@ -59,7 +59,7 @@ class VulnerabilityProcessor
         # use from the top of the top of the randomised list
         return_vulns[vulnerability_query.id] = search_list[0]
         if search_list[0].type.length > 0
-          puts "Selected vulnerability : " + search_list[0].type
+          puts "Selected vulnerability : " + search_list[0].name
         end
 
         # enforce only one of any vulnerability type (remove from available)

modules/environments/production/environment.conf

@@ -1 +0,0 @@
-default_manifest = "../../mount/puppet/manifest"

modules/vulnerabilities/unix/misc/distcc_exec/distcc_exec.pp

@@ -1 +1,3 @@
-include distcc_exec::config
+include distcc_exec::install
+include distcc_exec::config
+include distcc_exec::service

modules/vulnerabilities/unix/misc/distcc_exec/distcc_exec/manifests/config.pp

@@ -0,0 +1,10 @@
+class distcc_exec::config{
+  file { '/etc/default/distcc':
+    require => Package['distcc'],
+    ensure  => present,
+    owner   => 'root',
+    group   => 'root',
+    mode    => '0777',
+    content  => template('distcc_exec/distcc.erb')
+  }
+}

modules/vulnerabilities/unix/misc/distcc_exec/distcc_exec/manifests/distcc_config.pp

@@ -1,23 +0,0 @@
-class distcc_exec::distcc_config {
-
-  package { 'distcc':
-      ensure => installed
-  }
-
-
-  file { '/etc/default/distcc':
-    require => Package['distcc'],
-    ensure  => present,
-    owner   => 'root',
-    group   => 'root',
-    mode    => '0777',
-    content  => template('distcc.erb')
-  }
-
-
-  service { 'distcc':
-    ensure => running
-}
-}
-
-

modules/vulnerabilities/unix/misc/distcc_exec/distcc_exec/manifests/install.pp

@@ -0,0 +1,5 @@
+class distcc_exec::install{
+  package { 'distcc':
+    ensure => installed
+  }
+}

modules/vulnerabilities/unix/misc/distcc_exec/distcc_exec/manifests/service.pp

@@ -0,0 +1,5 @@
+class distcc_exec::service{
+  service { 'distcc':
+    ensure => running
+  }
+}