cybersecurity/BreakEscape
1
0
Fork 0
mirror of https://github.com/cliffe/BreakEscape.git synced 2026-02-21 11:18:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

Refactor note removal logic in Notes Minigame: Update the method for removing notes from the scene to align with the inventory system. Replace sprite-based checks with objectId references for improved consistency and clarity. Enhance visibility management for room objects and update scene object lists accordingly.

Browse Source
This commit is contained in:
Z. Cliffe Schreuders
2025-10-10 02:42:12 +01:00
parent b8c8c79f86
commit 039a76d5cc
1 changed files with 15 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
js/minigames/notes/notes-minigame.js
View File

@@ -411,23 +411,28 @@ export class NotesMinigame extends MinigameScene {
removeNoteFromScene() {
// Remove the note from the scene if it has a sprite
if (this.item && this.item.sprite) {
console.log('Removing note from scene:', this.item.sprite);
// Remove the note from the scene using the same method as the inventory system
if (this.item && this.item.objectId) {
console.log('Removing note from scene:', this.item.objectId);
// Hide the sprite
if (this.item.sprite.setVisible) {
this.item.sprite.setVisible(false);
if (this.item.setVisible) {
this.item.setVisible(false);
}
// Remove from scene if it has a destroy method
if (this.item.sprite.destroy) {
this.item.sprite.destroy();
// Remove from room objects if it exists (same as inventory system)
if (window.currentPlayerRoom && window.rooms && window.rooms[window.currentPlayerRoom] && window.rooms[window.currentPlayerRoom].objects) {
if (window.rooms[window.currentPlayerRoom].objects[this.item.objectId]) {
const roomObj = window.rooms[window.currentPlayerRoom].objects[this.item.objectId];
roomObj.setVisible(false);
roomObj.active = false;
console.log(`Removed object ${this.item.objectId} from room`);
}
}
// Also try to remove from the scene's object list if available
if (this.item.scene && this.item.scene.objects) {
const objectIndex = this.item.scene.objects.findIndex(obj => obj.sprite === this.item.sprite);
const objectIndex = this.item.scene.objects.findIndex(obj => obj.objectId === this.item.objectId);
if (objectIndex !== -1) {
this.item.scene.objects.splice(objectIndex, 1);
console.log('Removed note from scene objects list');
@@ -436,7 +441,7 @@ export class NotesMinigame extends MinigameScene {
// Update the scene's interactive objects if available
if (this.item.scene && this.item.scene.interactiveObjects) {
const interactiveIndex = this.item.scene.interactiveObjects.findIndex(obj => obj.sprite === this.item.sprite);
const interactiveIndex = this.item.scene.interactiveObjects.findIndex(obj => obj.objectId === this.item.objectId);
if (interactiveIndex !== -1) {
this.item.scene.interactiveObjects.splice(interactiveIndex, 1);
console.log('Removed note from scene interactive objects list');