From 52f7230e1670d1ae321a962fc355d4783d1d079d Mon Sep 17 00:00:00 2001
From: thomashaw <thomashaw@gmail.com>
Date: Mon, 13 Jun 2016 18:45:19 +0100
Subject: [PATCH] PR 33: Minor changes

---
 lib/schemas/service_metadata_schema.xsd                      | 1 +
 modules/services/unix/update/unix_update/manifests/unix.pp   | 5 -----
 modules/services/unix/update/unix_update/secgen_metadata.xml | 1 -
 .../windows/update/windows_update/secgen_metadata.xml        | 4 ++--
 scenarios/simple_examples/clean_system_with_update_unix.xml  | 3 +--
 5 files changed, 4 insertions(+), 10 deletions(-)

diff --git a/lib/schemas/service_metadata_schema.xsd b/lib/schemas/service_metadata_schema.xsd
index 2a9baddbc..c1189e1b7 100644
--- a/lib/schemas/service_metadata_schema.xsd
+++ b/lib/schemas/service_metadata_schema.xsd
@@ -8,6 +8,7 @@
     <xs:restriction base="xs:string">
       <xs:enumeration value="linux"/>
       <xs:enumeration value="unix"/>
+      <xs:enumeration value="windows"/>
     </xs:restriction>
   </xs:simpleType>
 
diff --git a/modules/services/unix/update/unix_update/manifests/unix.pp b/modules/services/unix/update/unix_update/manifests/unix.pp
index bfdb05d09..d2d2dd093 100644
--- a/modules/services/unix/update/unix_update/manifests/unix.pp
+++ b/modules/services/unix/update/unix_update/manifests/unix.pp
@@ -25,10 +25,5 @@ class unix_update::unix{
         command => "pkg update"
       }
     }
-    # 'MacOS': {
-    #   exec { 'update':
-    #     command => ""
-    #   }
-    # }
   }
 }
\ No newline at end of file
diff --git a/modules/services/unix/update/unix_update/secgen_metadata.xml b/modules/services/unix/update/unix_update/secgen_metadata.xml
index 820418f68..cfcba6138 100644
--- a/modules/services/unix/update/unix_update/secgen_metadata.xml
+++ b/modules/services/unix/update/unix_update/secgen_metadata.xml
@@ -12,7 +12,6 @@
   <platform>linux</platform>
 
   <!--optional details-->
-  <reference></reference>
   <software_name>unix_update</software_name>
   <software_license>Apache v2</software_license>
 
diff --git a/modules/services/windows/update/windows_update/secgen_metadata.xml b/modules/services/windows/update/windows_update/secgen_metadata.xml
index b402b20b0..01a6e4ff1 100644
--- a/modules/services/windows/update/windows_update/secgen_metadata.xml
+++ b/modules/services/windows/update/windows_update/secgen_metadata.xml
@@ -9,10 +9,10 @@
   <description>An update module for windows</description>
 
   <type>update</type>
-  <platform>linux</platform>
+  <platform>windows</platform>
 
   <!--optional details-->
-  <reference></reference>
+  <reference>https://github.com/voxpupuli/puppet-windows_autoupdate</reference>
   <software_name>windows_update</software_name>
   <software_license>MIT</software_license>
 
diff --git a/scenarios/simple_examples/clean_system_with_update_unix.xml b/scenarios/simple_examples/clean_system_with_update_unix.xml
index c71ee6e4c..d99084aeb 100644
--- a/scenarios/simple_examples/clean_system_with_update_unix.xml
+++ b/scenarios/simple_examples/clean_system_with_update_unix.xml
@@ -4,14 +4,13 @@
           xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
           xsi:schemaLocation="http://www.github/cliffe/SecGen/scenario">
 
-  <!-- an example remote storage system, with a remotely exploitable vulnerability that can then be escalated to root -->
+  <!-- an example of a clean and updated linux system -->
   <system>
     <system_name>clean_system_with_update</system_name>
     <base platform="linux"/>
 
     <service module_path="modules/services/unix/update/unix_update"></service>
 
-    <!--<network type="private_network" range="dhcp"></network>-->
   </system>
 
 </scenario>