mirror of
https://github.com/cliffe/BreakEscape.git
synced 2026-02-21 19:28:03 +00:00
acc793815b
BREAKING CHANGE: Updated conversation ending behavior Old Pattern (WRONG): - Conversations ended with #exit_conversation - Diverted to -> END (lost state) - Game code navigated back to mission_hub - State not preserved between interactions New Pattern (CORRECT): - Conversations end with #end_conversation - Divert to -> mission_hub (preserves state) - Game code closes UI window - Next interaction resumes from mission_hub with full context Why This Matters: - State preservation: NPC remembers where conversation left off - Flexible re-entry: Player can talk to NPC multiple times - Context awareness: Hub can show different options based on prior discussions Files Changed: - All *_ongoing_conversations.ink files: Updated conversation_end knots - Changed #exit_conversation -> #end_conversation - Changed -> END -> -> mission_hub - PersonChatConversation.js: Renamed handleExitConversation -> handleEndConversation - Now dispatches 'npc-conversation-ended' event to close UI - Ink handles state preservation via -> mission_hub - PhoneChatConversation.js: Same changes as PersonChatConversation - INK_BEST_PRACTICES.md: Updated documentation with correct pattern - Fixed conversation ending examples - Updated checklists - Added state preservation explanation - NPC_HUB_ARCHITECTURE.md: Updated mission hub flow documentation - Recompiled all hub JSON files This ensures conversation state is properly maintained across multiple interactions with the same NPC within a play session.