From 2d600ccb5b758ab2b046cdbe0fb460607136359d Mon Sep 17 00:00:00 2001 From: Sebastian Raschka Date: Wed, 18 Feb 2026 22:35:57 -0500 Subject: [PATCH] Use correct input in layernorm example (#960) * Update CI * Use correct example in layernorm section * update --- ch04/01_main-chapter-code/ch04.ipynb | 30 ++++++++++++++++++---------- reasoning-from-scratch | 2 +- 2 files changed, 20 insertions(+), 12 deletions(-) diff --git a/ch04/01_main-chapter-code/ch04.ipynb b/ch04/01_main-chapter-code/ch04.ipynb index 59bb28c..9df7822 100644 --- a/ch04/01_main-chapter-code/ch04.ipynb +++ b/ch04/01_main-chapter-code/ch04.ipynb @@ -38,9 +38,9 @@ "name": "stdout", "output_type": "stream", "text": [ - "matplotlib version: 3.10.0\n", - "torch version: 2.6.0\n", - "tiktoken version: 0.9.0\n" + "matplotlib version: 3.10.8\n", + "torch version: 2.10.0\n", + "tiktoken version: 0.12.0\n" ] } ], @@ -492,8 +492,8 @@ "output_type": "stream", "text": [ "Mean:\n", - " tensor([[ -0.0000],\n", - " [ 0.0000]], grad_fn=)\n", + " tensor([[-0.0000],\n", + " [ 0.0000]], grad_fn=)\n", "Variance:\n", " tensor([[1.0000],\n", " [1.0000]], grad_fn=)\n" @@ -564,8 +564,8 @@ "metadata": {}, "outputs": [], "source": [ - "ln = LayerNorm(emb_dim=5)\n", - "out_ln = ln(batch_example)" + "ln = LayerNorm(emb_dim=6)\n", + "out_ln = ln(out)" ] }, { @@ -579,11 +579,11 @@ "output_type": "stream", "text": [ "Mean:\n", - " tensor([[ -0.0000],\n", - " [ 0.0000]], grad_fn=)\n", + " tensor([[-0.0000],\n", + " [-0.0000]], grad_fn=)\n", "Variance:\n", - " tensor([[1.0000],\n", - " [1.0000]], grad_fn=)\n" + " tensor([[0.9995],\n", + " [0.9997]], grad_fn=)\n" ] } ], @@ -595,6 +595,14 @@ "print(\"Variance:\\n\", var)" ] }, + { + "cell_type": "markdown", + "id": "07220af7-cf53-48c8-8831-813a7088edea", + "metadata": {}, + "source": [ + "- Variance is not exactly 1 because we use `eps`" + ] + }, { "cell_type": "markdown", "id": "e136cfc4-7c89-492e-b120-758c272bca8c", diff --git a/reasoning-from-scratch b/reasoning-from-scratch index edcae1d..7b6a9d0 160000 --- a/reasoning-from-scratch +++ b/reasoning-from-scratch @@ -1 +1 @@ -Subproject commit edcae1d894192a2d7c036bfea43922cb140dea10 +Subproject commit 7b6a9d0f9090201dcb66c6242812d29aec379c77